Update resource list to Polaris v3.10.0 #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙄 |
vladucu
approved these changes
Apr 2, 2019
| @@ -221,6 +222,7 @@ export default Component.extend(context.ConsumerMixin, { | |||
| 'selectMode', | |||
| 'element' | |||
| ); | |||
| let { ctrlKey, metaKey } = event; | |||
There was a problem hiding this comment.
should this be event.nativeEvent?
There was a problem hiding this comment.
No, React wraps all event objects in a SyntheticEvent class, whose nativeEvent property is the underlying browser event. We don't seem to have to worry about such things in Ember-land 🙌
| @@ -69,7 +73,7 @@ | |||
| </div> | |||
| {{/if}} | |||
|
|
|||
| {{#if shortcutActions}} | |||
| {{#if (and shortcutActions (not loading))}} | |||
| {{#wrapper-element | |||
There was a problem hiding this comment.
why do we use this wrapper-element here?
There was a problem hiding this comment.
I think to handle the click and gain access to the event so that we can stop it propagating I think, this was from a while ago 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
alternateTooltopolaris-resource-list, improves handling of loading state, improves item link handling on click events, and updates the resource list subcomponents with the tweaks from Polaris v3.10.0.