Prevent bubbling from links #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladucu
approved these changes
Jul 7, 2017
| @@ -18,7 +18,7 @@ moduleForComponent('polaris-icon', 'Integration, Component, polaris icon', { | |||
|
|
|||
| const iconSelector = 'span.Polaris-Icon'; | |||
|
|
|||
| test('it renders the specified icon correctly', function(assert) { | |||
| skip('it renders the specified icon correctly', function(assert) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, clicking a
polaris-link(both the link and button variants) would bubble, resulting in unwanted behaviour. To resolve this I've introduced an internalpolaris-unstyled-linkas per the React implementation, which prevents click propagation, and stopped bubbling on the button link's action handler.I've also skipped SVG-related tests so we can see at a glance if we have any new test failures.