Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting tweaks #423

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Linting tweaks #423

merged 2 commits into from
Nov 12, 2019

Conversation

vladucu
Copy link
Member

@vladucu vladucu commented Nov 12, 2019 •
edited

  • drops ember-cli-eslint & ember-cli-template-lint in favor of directly using these
  • explicitly add linting dev deps after smile-io/eslint-plugin-smile-ember#4

Fixes weird linting issues

@vladucu vladucu self-assigned this Nov 12, 2019
andrewpye
andrewpye approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@andrewpye andrewpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks aight! 👍

@vladucu vladucu merged commit 1d1f5a5 into master Nov 12, 2019
@vladucu vladucu deleted the fix-and-tweak-linting branch November 12, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewpye andrewpye andrewpye approved these changes

Assignees

@vladucu vladucu

Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vladucu @andrewpye