Modernize polaris-text-style component #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladucu
requested changes
Feb 7, 2020
| @@ -6,23 +6,23 @@ | |||
| component instance once that instance has been created :sadface: | |||
| --}} | |||
| {{#with (component "wrapper-element" | |||
There was a problem hiding this comment.
there's a new element helper provided by ember-element-helper that should clean this up a bit and get rid of using our custom wrapper-element here (check an example here)
vladucu
approved these changes
Feb 10, 2020
Co-Authored-By: vladucu <vanca.vlad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEV-86
Updates
PolarisTextStyleto tagless component, ES6 classes, and angle bracket syntax.Dummy app: