Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize polaris-option-list components #510

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Modernize polaris-option-list components #510

merged 2 commits into from
Feb 18, 2020

Conversation

tomnez
Copy link
Contributor

@tomnez tomnez commented Feb 18, 2020

DEV-71

Updates PolarisOptionList and subcompoents to tagless components, ES6 classes, and angle bracket syntax.

Dummy app:

options

@tomnez tomnez self-assigned this Feb 18, 2020
andrewpye
andrewpye approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@andrewpye andrewpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with me assuming tests pass! 🚀

vladucu
vladucu approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@vladucu vladucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tomnez tomnez merged commit 7f5fa6f into refactor/es6-classes Feb 18, 2020
@tomnez tomnez deleted the refactor/es6-polaris-option-list-DEV-71 branch February 18, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladucu vladucu vladucu approved these changes

@andrewpye andrewpye andrewpye approved these changes

Assignees

@tomnez tomnez

Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomnez @vladucu @andrewpye