Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize text-container component #602

Merged
merged 3 commits into from
Jun 19, 2020

Conversation

vladucu
Copy link
Member

@vladucu vladucu commented Jun 19, 2020

No description provided.

@vladucu vladucu self-assigned this Jun 19, 2020
@vladucu vladucu marked this pull request as ready for review June 19, 2020 10:41
if (allowedSpacings.indexOf(spacing) > -1) {
return `Polaris-TextContainer--spacing${classify(spacing)}`;
@(computed('spacing').readOnly())
get spacingClass() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to mark this as readOnly since we've only defined the getter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@sivakumar-kailasam sivakumar-kailasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor feedback, but looks good otherwise.

@vladucu vladucu force-pushed the refactor/es6-text-container branch from 9e57ec3 to a651b9e Compare June 19, 2020 15:50
@vladucu vladucu merged commit 6970c1a into refactor/es6-classes Jun 19, 2020
@vladucu vladucu deleted the refactor/es6-text-container branch June 19, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants