Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize spinner component #611

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Modernize spinner component #611

merged 1 commit into from
Jun 22, 2020

Conversation

vladucu
Copy link
Member

@vladucu vladucu commented Jun 22, 2020

No description provided.

@vladucu vladucu self-assigned this Jun 22, 2020
tomnez
tomnez approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@tomnez tomnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple CP's that reuse the same value rather than setting a var (this.color and this.size) but I'm fine with leaving it if no one else minds it 🤷

@vladucu
Copy link
Member Author

vladucu commented Jun 22, 2020

There's a couple CP's that reuse the same value rather than setting a var (this.color and this.size) but I'm fine with leaving it if no one else minds it 🤷

those 👁️
yeah, I think that should be fine... we shouldn't always just reach for destructuring IMO

@tomnez
Copy link
Contributor

tomnez commented Jun 22, 2020

yeah, I think that should be fine... we shouldn't always just reach for destructuring IMO

kk, I'll ignore if it pops up in other PR's then 👍

@vladucu vladucu merged commit cd0769e into refactor/es6-classes Jun 22, 2020
@vladucu vladucu deleted the refactor/es6-spinner branch June 22, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomnez tomnez tomnez approved these changes

@sivakumar-kailasam sivakumar-kailasam Awaiting requested review from sivakumar-kailasam

Assignees

@vladucu vladucu

Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vladucu @tomnez