Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize date-picker component #619

Merged
merged 8 commits into from
Jun 23, 2020

Conversation

vladucu
Copy link
Member

@vladucu vladucu commented Jun 23, 2020

Had to skip some tests for the ResourceList which is using the date-picker. I'd like to get this in since it's the last component and as part of a cleanup re-circle back to theses tests.

@vladucu vladucu self-assigned this Jun 23, 2020
@vladucu vladucu marked this pull request as ready for review June 23, 2020 15:09
@vladucu vladucu requested review from andrewpye and tomnez June 23, 2020 15:09
Copy link
Contributor

@tomnez tomnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew these files give me flashbacks 😅 Looks good assuming it got a good test run.

@vladucu
Copy link
Member Author

vladucu commented Jun 23, 2020

Whew these files give me flashbacks 😅

lmao

Looks good assuming it got a good test run.

welp, fun only now begins 😬

@vladucu vladucu merged commit fba307c into refactor/es6-classes Jun 23, 2020
@vladucu vladucu deleted the refactor/es6-date-picker branch June 23, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants