Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop currying click event to action handlers #630

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Conversation

vladucu
Copy link
Member

@vladucu vladucu commented Jun 29, 2020

When we replaced usage of mapEventToAction utility for click handlers, we
introduced back currying of the click event to the action handlers. This fixes
it.

@vladucu vladucu self-assigned this Jun 29, 2020
@vladucu vladucu requested review from andrewpye and tomnez June 29, 2020 16:38
Copy link
Member

@andrewpye andrewpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me I think. One question that I had is whether we need to stop event propagation in our handleClick actions before invoking onClick etc. 🤔

@vladucu
Copy link
Member Author

vladucu commented Jun 30, 2020

Makes sense to me I think. One question that I had is whether we need to stop event propagation in our handleClick actions before invoking onClick etc.

Will check to make sure we match React implementation, just to be sure. Good shout!

@vladucu vladucu merged commit d11e614 into v6 Jun 30, 2020
@vladucu vladucu deleted the fix-click-handlers branch June 30, 2020 17:12
@vladucu vladucu changed the title Stop curring click event to action handlers Stop currying click event to action handlers Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants