Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yielded section in sectioned card #642

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Conversation

andrewpye
Copy link
Member

Found this morning that when using a PolarisCard with @sectioned={{true}} in block mode, the yielded hash looks like {section: undefined} 馃槵 This change makes sure section is populated correctly, and also adds a Section property as a parallel to the yielded hash when PolarisCard is used without @sectioned={{true}}.

@andrewpye andrewpye requested a review from vladucu July 20, 2020 08:19
@andrewpye andrewpye self-assigned this Jul 20, 2020
@andrewpye andrewpye added the bug Something isn't working label Jul 20, 2020
@andrewpye andrewpye merged commit c4da047 into master Jul 20, 2020
@andrewpye andrewpye deleted the fix/yielded-card-section branch July 20, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants