Update dependency eslint to v7 #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
requested review from
a team and
sivakumar-kailasam
and removed request for
a team
|
@vladucu added you as a reviewer for extra 👀 since i made some code changes |
vladucu
approved these changes
Jul 27, 2020
| set id(value) { | ||
| this._id = value; | ||
| return value; |
There was a problem hiding this comment.
just double-checking, we don't need to explicitly return?
There was a problem hiding this comment.
No, setter values are ignored by the JS runtime(the eslint rule docs has more info on this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
6.8.0->7.5.0Release Notes
eslint/eslint
v7.5.0Compare Source
6ea3178Update: optional chaining support (fixes #12642) (#13416) (Toru Nagashima)540b1afChore: enable consistent-meta-messages internal rule (#13487) (Milos Djermanovic)885a145Docs: clarify behavior ifmeta.fixableis omitted (refs #13349) (#13493) (Milos Djermanovic)1a01b42Docs: Update technology sponsors in README (#13478) (Nicholas C. Zakas)6ed9e8eUpgrade: lodash@4.17.19 (#13499) (Yohan Siguret)45cdf00Sponsors: Sync README with website (ESLint Jenkins)f1cc725Docs: fix linebreaks between versions in changelog (#13488) (Milos Djermanovic)f4d7b9eUpdate: deprecate id-blacklist rule (#13465) (Dimitri Mitropoulos)e14a645Chore: use espree.latestEcmaVersion in fuzzer (#13484) (Milos Djermanovic)61097feDocs: Update int rule level to string (#13483) (Brandon Mills)c8f9c82Update: Improve report location no-irregular-whitespace (refs #12334) (#13462) (Milos Djermanovic)f2e68ecBuild: update webpack resolve.mainFields to match website config (#13457) (Milos Djermanovic)a96bc5eFix: arrow-body-style fixer forinwrap (fixes #11849) (#13228) (Anix)748734fUpgrade: Updated puppeteer version to v4.0.0 (#13444) (odidev)e951457Docs: fix wording in configuring.md (#13469) (Piper)0af1d28Update: add allowSeparatedGroups option to sort-imports (fixes #12951) (#13455) (Milos Djermanovic)1050ee7Update: Improve report location for no-unneeded-ternary (refs #12334) (#13456) (Milos Djermanovic)b77b420Update: Improve report location for max-len (refs #12334) (#13458) (Milos Djermanovic)095194cFix: add end location to reports in object-curly-newline (refs #12334) (#13460) (Milos Djermanovic)10251bbFix: add end location to reports in keyword-spacing (refs #12334) (#13461) (Milos Djermanovic)2ea7ee5Sponsors: Sync README with website (ESLint Jenkins)b55fd3bSponsors: Sync README with website (ESLint Jenkins)v7.4.0Compare Source
f21bad2Docs: fix description forneverin multiline-ternary (fixes #13368) (#13452) (Milos Djermanovic)ada2c89Fix: support typescript generics in arrow-parens (fixes #12570) (#13451) (Milos Djermanovic)89ee01eFix: Revert config cloning (fixes #13447) (#13449) (薛定谔的猫)0a463dbDocs: fix no-multiple-empty-lines examples (fixes #13432) (#13433) (Milos Djermanovic)ff5317eUpdate: Improve array-callback-return report message (#13395) (Philip (flip) Kromer)3f51930Fix: false positive new with member in no-extra-parens (fixes #12740) (#13375) (YeonJuan)825a5b9Fix: Clarify documentation on implicit ignore behavior (fixes #12348) (#12600) (Scott Hardin)c139156Sponsors: Sync README with website (ESLint Jenkins)0c17e9dSponsors: Sync README with website (ESLint Jenkins)c680387Sponsors: Sync README with website (ESLint Jenkins)bf3939bSponsors: Sync README with website (ESLint Jenkins)7baf02eSponsors: Sync README with website (ESLint Jenkins)5c4c3fdSponsors: Sync README with website (ESLint Jenkins)53912aaSponsors: Sync README with website (ESLint Jenkins)51e42ecUpdate: Add option "ignoreGlobals" to camelcase rule (fixes #11716) (#12782) (David Gasperoni)0655f66Update: improve report location in arrow-body-style (refs #12334) (#13424) (YeonJuan)d53d69aUpdate: prefer-regex-literal detect regex literals (fixes #12840) (#12842) (Mathias Schreck)004adaeUpdate: rename id-blacklist to id-denylist (fixes #13407) (#13408) (Kai Cataldo)v7.3.1Compare Source
de77c11Fix: Replace Infinity with Number.MAX_SAFE_INTEGER (fixes #13427) (#13435) (Nicholas C. Zakas)v7.3.0Compare Source
638a6d6Update: add missingadditionalProperties: falseto some rules' schema (#13198) (Milos Djermanovic)949a5cdUpdate: fix operator-linebreak overrides schema (#13199) (Milos Djermanovic)9e1414eNew: Add no-promise-executor-return rule (fixes #12640) (#12648) (Milos Djermanovic)09cc0a2Update: max-lines reporting loc improvement (refs #12334) (#13318) (Anix)ee2fc2eUpdate: object-property-newline end location (refs #12334) (#13399) (Anix)d98152aUpdate: added empty error array check for false negative (#13200) (Anix)7fb45cfFix: clone config before validating (fixes #12592) (#13034) (Anix)aed46f6Sponsors: Sync README with website (ESLint Jenkins)7686d7fUpdate: semi-spacing should check do-while statements (#13358) (Milos Djermanovic)cbd0d00Update: disallow multiple options in comma-dangle schema (fixes #13165) (#13166) (Milos Djermanovic)b550330New: Add no-unreachable-loop rule (fixes #12381) (#12660) (Milos Djermanovic)13999d2Update: curly should check consequentifstatements (#12947) (Milos Djermanovic)c42e548Chore: enable exceptRange option in the yoda rule (#12857) (Milos Djermanovic)6cfbd03Update: Drop @typescript-eslint/eslint-recommended fromeslint --init(#13340) (Minh Nguyen)796f269Chore: update eslint-config-eslint's required node version (#13379) (薛定谔的猫)9d0186eDocs: Fix changelog versions (#13410) (Tony Brix)1ee3c42Docs: On maxEOF with eol-last (fixes #12742) (#13374) (Arthur Dias)2a21049Update: key-spacing loc changes for extra space (refs #12334) (#13362) (Anix)7ce7988Chore: Replace the inquirer dependency with enquirer (#13254) (Selwyn)0f1f5edDocs: Add security policy link to README (#13403) (Nicholas C. Zakas)9e9ba89Sponsors: Sync README with website (ESLint Jenkins)ca59fb9Sponsors: Sync README with website (ESLint Jenkins)v7.2.0Compare Source
b735a48Update: add enforceForFunctionPrototypeMethods option to no-extra-parens (#12895) (Milos Djermanovic)27ef73fUpdate: reporter locr of func-call-spacing (refs #12334) (#13311) (Anix)353bfe9Update: handle parentheses in multiline-ternary (fixes #13195) (#13367) (Milos Djermanovic)a7fd343Update: keyword-spacing unexpected space loc improve (refs #12334) (#13377) (Anix)e49732eFix: Ignore import expressions in no-unused-expressions rule (#13387) (Veniamin Krol)220349fChore: Remove duplicate health files (#13380) (Nicholas C. Zakas)dd949aeUpdate: support??operator, import.meta, andexport * as ns(#13196) (Toru Nagashima)d5fce9fUpdate: enable es2020 environment in --init (#13357) (Milos Djermanovic)21b1583Docs: fixed broken hash link for working-with-rules.md (#13386) (Yosuke Ota)b76aef7Update: Improve report location for template-tag-spacing (refs #12334) (#13203) (Milos Djermanovic)578efadChore: update no-unused-vars caughtErrors in eslint-config-eslint (#13351) (Milos Djermanovic)426088cFix: no-unused-vars updated location to last reference (fixes #13181) (#13354) (Anix)cb50b69Update: Improve location for no-mixed-spaces-and-tabs (refs #12334) (#13365) (Milos Djermanovic)f858f2aChore: Add Tidelift to funding.yml (#13371) (Nicholas C. Zakas)ee30e5dSponsors: Sync README with website (ESLint Jenkins)c29bd9fChore: Add breaking/core change link to issue templates (#13344) (Kai Cataldo)d55490fSponsors: Sync README with website (ESLint Jenkins)v7.1.0Compare Source
a93083aFix: astUtils.getNextLocation returns invalid location after CRLF (#13275) (Milos Djermanovic)df01af1Update: padded-blocks loc position changes (refs #12334) (#13328) (Anix)bd3f092Fix: max-lines-per-function flagging arrow IIFEs (fixes #13332) (#13336) (cherryblossom000)25462b2Update: block-spacing changed loc for extra (refs #12334) (#13314) (Anix)de0aab9Fix: report end loc in one-var-declaration-per-line (refs #12334) (#13326) (YeonJuan)1710296Fix: no-new-symbol false positive with Symbol as an argument (#13337) (Milos Djermanovic)cc01451Fix: arrow-parens no reporting for comments inside (fixes #12995) (#13312) (Anix)a195141Update: reporting location for semi-spacing (refs #12334) (#13285) (Anix)e3e4c41Fix: fix false positives of no-new-func (#13333) (Pig Fang)611c676Docs: Update new rules policies (#13343) (Nicholas C. Zakas)3a5fbb3Chore: correct fileoverview doc in accessor-pairs (#13335) (YeonJuan)b0a6b81Update: Improve report location for rest-spread-spacing (refs #12334) (#13313) (Milos Djermanovic)68c8ee3Fix: Stop path analyzer on unknown nodes (#13305) (Ilya Volodin)89e1081Update: Improve report location for linebreak-style (refs #12334) (#13317) (Milos Djermanovic)0891379Docs: Document the "correct" way to build an array with values (#13246) (Ed S)88127d7Chore: remove checkbox from PR template prerequesites (#13330) (Kai Cataldo)c636d57New: no-loss-of-precision (fixes #11279) (#12747) (jmoore914)72a4e10Chore: Mark SourceCode getComments() method as deprecated (fixes #13293) (#13296) (SuperOleg39)7f14846Docs: fix broken link in Node.js API docs (#13307) (Kai Cataldo)02aeba1Sponsors: Sync README with website (ESLint Jenkins)1f17533Docs: Gitter -> Discord URL (refs #13039) (#13308) (Nicholas C. Zakas)82a448aDocs: improve documentation of no-return-await (#13215) (Linus Unnebäck)742941dUpdate: added typescript-eslint/recommended configs for init (#13235) (Anix)3d03df0Sponsors: Sync README with website (ESLint Jenkins)f44a6b4Chore: fix invalid syntax in require-await tests (#13277) (Milos Djermanovic)2c778fbFix: remove custom plugins from replacedBy metadata (#13274) (Kai Cataldo)0db3b1dSponsors: Sync README with website (ESLint Jenkins)v7.0.0Compare Source
b98d8bdUpgrade: eslint-release@2.0.0 (#13271) (Kai Cataldo)4c0b028Fix: remove Node.js and CommonJS category from build process (#13242) (Kai Cataldo)401a687Chore: fix rules list for prereleases (#13230) (Kai Cataldo)4ef6158Breaking: espree@7.0.0 (#13270) (Kai Cataldo)b5c8d73Docs: update 7.0.0 migration guide for consistency (#13267) (Kai Cataldo)356fdb4Docs: add migration guide (#12692) (Toru Nagashima)015edf6Sponsors: Sync README with website (ESLint Jenkins)fdfa3647.0.0-rc.0 (ESLint Jenkins)8d1b4dbBuild: changelog update for 7.0.0-rc.0 (ESLint Jenkins)0b1d65aUpdate: Improve report location for array-callback-return (refs #12334) (#13109) (Milos Djermanovic)d85e291Fix: yoda left string fix for exceptRange (fixes #12883) (#13052) (Anix)2ce6bedChore: added tests for nested arrays (#13145) (Anix)d3aac53Update: report backtick loc in no-unexpected-multiline (refs #12334) (#13142) (Milos Djermanovic)8e7a2d9Fix: func-call-spacing "never" reports wrong message (fixes #13190) (#13193) (Milos Djermanovic)bcafd0fUpdate: Add ESLint API (refs eslint/rfcs#40) (#12939) (Kai Cataldo)3eeae56Upgrade: some (dev) deps (#13155) (薛定谔的猫)6b7030bChore: Run tests on Node.js v14 (#13210) (fisker Cheung)ebc28d7Fix: Remove default .js from --ext CLI option (#13176) (Brandon Mills)5c1bdebUpdate: Improve report location for getter-return (refs #12334) (#13164) (Milos Djermanovic)56d2beeDocs: fix typos (#13204) (Nitin Kumar)e13256eChore: use espree.latestEcmaVersion in config-initializer (#13157) (Kai Cataldo)e4f57b7Chore: add nested array tests for array-element-newline (#13161) (Anix)63ac918Sponsors: Sync README with website (ESLint Jenkins)516f253Docs: Adds import example for object-curly-newline rule (refs #12018) (#13177) (Luke Lewis)5a0e84eSponsors: Sync README with website (ESLint Jenkins)b398e0bDocs: add rule comment in prefer-rest-params doc (#13191) (YeonJuan)ffaa4baSponsors: Sync README with website (ESLint Jenkins)932869bSponsors: Sync README with website (ESLint Jenkins)54630f0Sponsors: Sync README with website (ESLint Jenkins)c9a5035Fix: newBasePath should be an absolute path (fixes #12850) (#13078) (Nick Harris)e7c1d4bUpdate: deprecate Node.js & CommonJS rules (#12898) (Kai Cataldo)95e1c70Upgrade: levn@0.4.1 (fixes #9366) (#13140) (Kai Cataldo)c41de38Docs: fix curly multi-or-nest examples with comments (refs #12972) (#13151) (Milos Djermanovic)57221d5Docs: fix eslint comment in no-inner-declarations examples (#13152) (Milos Djermanovic)301b450Fix: no-extra-parens export default sequence expression false positive (#13096) (Milos Djermanovic)af4472fUpdate: Improve report location for new-cap (refs #12334) (#13136) (Milos Djermanovic)bfa811cFix: init error in extending recommended config (fixes #12707) (#12738) (YeonJuan)5dfd4ebDocs: examples with arrow functions in no-return-assign (fixes #13135) (#13138) (Anix)adc8fa8Docs: clarify exceptions in spaced-comment (fixes #13032) (#13126) (Anix)a784dacUpdate: Improve report location newline-per-chained-call (refs #12334) (#13116) (Milos Djermanovic)5e07574Update: Improve report location for space-before-function-paren (#13128) (Chiawen Chen)d0d32a8Sponsors: Sync README with website (ESLint Jenkins)17e2fe4Update: Improve error message for fatal fixer errors (#13120) (Brad Zacher)7551f0cFix: no check for shadowed Object (fixes #12809) (#13115) (Anix)988d842Fix: add end location to report in no-useless-concat (refs #12334) (#13110) (Milos Djermanovic)0518ebbSponsors: Sync README with website (ESLint Jenkins)252fd41Sponsors: Sync README with website (ESLint Jenkins)438dcbbUpdate: Improve report location for comma-style (refs #12334) (#13111) (Chiawen Chen)85b7254Update: no-inner-declarations false negative in non-block (fixes #12222) (#13062) (Anix)6631ef1Update: Improve report location for no-empty-function (refs #12334) (#13121) (Milos Djermanovic)b228f95Docs: Update README team and sponsors (ESLint Jenkins)119b7ce7.0.0-alpha.3 (ESLint Jenkins)2531b80Build: changelog update for 7.0.0-alpha.3 (ESLint Jenkins)78c8cdaBreaking: RuleTester Improvements (refs eslint/rfcs#25) (#12955) (Milos Djermanovic)e0f1b6cUpdate: stricter array index check in no-magic-numbers (fixes #12845) (#12851) (Milos Djermanovic)362713cUpdate: Improve report location for template-curly-spacing (#12813) (Milos Djermanovic)29f32dbFix: Change error message logic for implicit file ignore (fixes #12873) (#12878) (Scott Hardin)eb1a43cFix: require-await ignore async generators (fixes #12459) (#13048) (Anix)920465bFix: getNameLocationInGlobalDirectiveComment end location (refs #12334) (#13086) (Milos Djermanovic)ae14a02Fix: add end location to report in no-extra-bind (refs #12334) (#13083) (Milos Djermanovic)105384cUpdate: report operator location in operator-linebreak (refs #12334) (#13102) (Milos Djermanovic)081e240Update: support globalThis in no-implied-eval (fixes #12670) (#13105) (YeonJuan)185982dBreaking: improve plugin resolving (refs eslint/rfcs#47) (#12922) (Toru Nagashima)0c20bc0Fix: check assignment property target in camelcase (fixes #13025) (#13027) (YeonJuan)8d50a7dFix: add end location to report in no-prototype-builtins (refs #12334) (#13087) (Milos Djermanovic)3e4e7f8Fix: incorrect logic for required parens in no-extra-boolean-cast fixer (#13061) (Milos Djermanovic)6c069f9Docs: Add comments to code block in example (#13089) (Kibeom Kwon)ee1f053Docs: Fix typo (#13092) (Max Coplan)76324acDocs: Add further reading to rule (#13084) (Max Coplan)a1370abUpdate: Report constructor calls in no-obj-calls (#12909) (Milos Djermanovic)2111c52Upgrade: esquery@1.2.0 (#13076) (Milos Djermanovic)3f7c9bfDocs: clarify variables option in no-use-before-define (fixes #12986) (#13017) (Anix)aef9488Fix: allow references to external globals in id-blacklist (fixes #12567) (#12987) (Milos Djermanovic)4955c50Fix: remove type arguments in prefer-object-spread (fixes #13058) (#13063) (Milos Djermanovic)48b122fBreaking: change relative paths with --config (refs eslint/rfcs#37) (#12887) (Toru Nagashima)085979fUpdate: consider env in no-implied-eval (fixes #12733) (#12757) (YeonJuan)9ac5b9eDocs: Clarify node_modules is ignored by default (fixes #13006) (#13054) (Mika Kuijpers)0de91f3Docs: removed correct code from incorrect eg (#13060) (Anix)dbe357dFix: check template literal in prefer-numeric-literals (fixes #13045) (#13046) (YeonJuan)2260611Fix: added async in allow method in no-empty-function (fixes #12768) (#13036) (Anix)f3788afSponsors: Sync README with website (ESLint Jenkins)e90b29bUpdate: Allow testing Suggestions with data in RuleTester (fixes #12606) (#12635) (Milos Djermanovic)7224eeeFix: no-plusplus allow comma operands in for afterthought (fixes #13005) (#13024) (Milos Djermanovic)7598cf8Fix: Newline before eof when creating config via --init (#12952) (Andreas Lind)183e300Update: support globalThis (refs #12670) (#12774) (YeonJuan)af7af9dDocs: Update governance (#13055) (Nicholas C. Zakas)31d5eb3Sponsors: Sync README with website (ESLint Jenkins)95613d4Upgrade: espree@6.2.1 (#13026) (Kai Cataldo)f1525dcSponsors: Sync README with website (ESLint Jenkins)0243549Fix: camelcase false positive with computed property (fixes #13022) (#13023) (Milos Djermanovic)bc0c02cChore: added lock files to gitignore (#13015) (Anix)79ac6cdDocs: added less confusing explanation for func-style (fixes #12900) (#13004) (Anix)26267edChore: update GitHub Actions (#12984) (Pig Fang)1299705Update: acorn version (#13016) (Idan Avrahami)6cef0d5Fix: Check division operator in astUtils.canTokensBeAdjacent (#12879) (Milos Djermanovic)fd8e1f5Sponsors: Sync README with website (ESLint Jenkins)472025fChore: update space-before-function-paren in eslint-config-eslint (#12966) (Kai Cataldo)fd8c42aSponsors: Sync README with website (ESLint Jenkins)c615eae7.0.0-alpha.2 (ESLint Jenkins)2e8f193Build: changelog update for 7.0.0-alpha.2 (ESLint Jenkins)a5b41a7Update: no-restricted-modules handle TemplateLiteral (fixes #12926) (#12927) (Michal Piechowiak)051567aUpdate: check identifier in array pattern in id-length (fixes #12832) (#12839) (YeonJuan)4af06fcBreaking: Test with an unknown error property should fail in RuleTester (#12096) (Milos Djermanovic)9038a29Update: func-namesas-neededfalse negative with AssignmentPattern (#12932) (Milos Djermanovic)afde78bFix: curly removes necessary braces between if and else (fixes #12928) (#12943) (Milos Djermanovic)4797fb2Fix: arrow-body-style crash with object literal body (fixes #12884) (#12886) (Milos Djermanovic)afa9aacBreaking: class defaulttruecomputed-property-spacing (fixes #12812) (#12915) (Milos Djermanovic)b8e20d3Docs: Mention TypeScript's compiler check (#12903) (Benny Neugebauer)de14d1cFix: wrap-iife autofix removes mandatory parentheses (#12905) (Milos Djermanovic)5775b06Fix: Optionally allow underscores in member names (#11972) (Edgardo Avilés)e997f32Docs: Updated arrow-parens for minor grammar issue (#12962) (Tom)7d52151Breaking: classes defaulttruein accessor-pairs (fixes #12811) (#12919) (Milos Djermanovic)cf14355Docs: Fix links to custom parsers doc (#12965) (Brandon Mills)0dfc3ffFix: add end location to report in no-eval (#12960) (Milos Djermanovic)f479f6fDocs: References correct config file name (#12885) (Patrick Kilgore)78182e4Breaking: Add new rules to eslint:recommended (fixes #12911) (#12920) (Milos Djermanovic)8d5c434Docs: fix category descriptions for site generation (fixes #12894) (#12930) (Kai Cataldo)05380e6Docs: Remove claim about semicolons from docs (#12944) (Luke Sikina)aa9d725Sponsors: Sync README with website (ESLint Jenkins)7747177Update: report rename id destructuring in id-blacklist (fixes #12807) (#12923) (YeonJuan)6423e11Breaking: check unnamed default export in func-names (fixes #12194) (#12195) (Chiawen Chen)77df505Update: check renaming identifier in object destructuring (fixes 12827) (#12881) (YeonJuan)41de9dfUpdate: enforceForLogicalOperands no-extra-boolean-cast (fixes #12137) (#12734) (jmoore914)98a9b017.0.0-alpha.1 (ESLint Jenkins)e9f1073Build: changelog update for 7.0.0-alpha.1 (ESLint Jenkins)f702b1aAdd missing plugin reference (#12796) (Eduard Bardají Puig)1f1424cFix: fix inconsistently works option in no-extra-parens (fixes #12717) (#12843) (YeonJuan)b5adcaa](https://togithub.Renovate configuration
📅 Schedule: "before 3am on Monday" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.