Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jquery dependency #658

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Remove jquery dependency #658

merged 2 commits into from
Oct 6, 2020

Conversation

vladucu
Copy link
Member

@vladucu vladucu commented Oct 6, 2020

No description provided.

@vladucu vladucu self-assigned this Oct 6, 2020
@vladucu vladucu marked this pull request as ready for review October 6, 2020 10:43
@vladucu vladucu added dependencies Pull requests that update a dependency file internal labels Oct 6, 2020
andrewpye
andrewpye approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@andrewpye andrewpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YEEESSSSS!!! 🔥🚀

@vladucu vladucu merged commit a5fd222 into master Oct 6, 2020
@vladucu vladucu deleted the drop-jquery branch October 6, 2020 10:47
tomnez
tomnez reviewed Oct 6, 2020
View reviewed changes
Copy link
Contributor

@tomnez tomnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@vladucu vladucu mentioned this pull request Oct 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomnez tomnez tomnez left review comments

@andrewpye andrewpye andrewpye approved these changes

Assignees

@vladucu vladucu

Labels
dependencies Pull requests that update a dependency file internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vladucu @tomnez @andrewpye