Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix banner primary action #669

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Fix banner primary action #669

merged 1 commit into from
Oct 28, 2020

Conversation

vladucu
Copy link
Member

@vladucu vladucu commented Oct 28, 2020

Fixes triggering the Banner's main action

@vladucu vladucu self-assigned this Oct 28, 2020
@vladucu vladucu requested a review from tomnez October 28, 2020 10:06
@vladucu vladucu added the bug Something isn't working label Oct 28, 2020
@vladucu vladucu requested a review from abd00s October 28, 2020 10:09
abd00s
abd00s approved these changes Oct 28, 2020
View reviewed changes
Copy link

@abd00s abd00s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm out of my element here, but looks good!

@vladucu vladucu merged commit 21b9ef1 into master Oct 28, 2020
@vladucu vladucu deleted the fix-banner-main-action branch October 28, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abd00s abd00s abd00s approved these changes

@tomnez tomnez Awaiting requested review from tomnez

Assignees

@vladucu vladucu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vladucu @abd00s