Update ember-basic-dropdown to latest release #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oof. I got mixed up after seeing this while scrolling through releases:
and thought that it referred to v2.0.15 🙄 |
|
yeah, been there done that 😂 |
|
Welp, looks like v2.0.15 doesn't fix the build error on Canary anyway. Here's hoping v3 does... 🙏 |
|
Turns out even latest |
vladucu
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
@andrewpye before merging, let's tweak this to allow canary build to fail by configuring it in config/ember-try.js (check allowedToFail in ember-try)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
ember-basic-dropdownto the most recent release (v3.0.11) with the aim of fixing a build error being seen in otherember-polarisPRs. The breaking changes involved in this update can be found in theember-basic-dropdownrelease notes.