Explicitly pass action to polaris page action #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivakumar-kailasam
requested review from
tomnez
and removed request for
vladucu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polaris action group didn't pass an
onActionto the underlyingPolarisPage::Actioncomponent and was relying on event bubbling for the popover's activator to work. With some recent changes to stop event propagation in that component, this stopped working. So this PR adds an implicitonActionparameter so that we don't run into any surprises in the future.Testing: verified that the functionality was broken on master by looking at the dummy app & validated that it works as expected with this change.