Fix broken Glimmer component detection #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladucu
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, component definitions in production switched to using Symbol keys instead of string keys. This broke our
is-component-definitionhelper, which resulted in some breakages elsewhere. This PR adds a rudimentary check for these new-style component definitions.This is at least the second time that this helper has broken as a result of Ember/Glimmer updates. I'm aware that we should be trying to figure out a way to remove it or make it less brittle/dependent on internals, but for the time being I think this workaround will have to do 😅
Demo of something now working after this change that was previously broken (the strong part of the help text was previously not updating because it was not receiving updates due to
is-component-definitionreturning a false negative):