[embroider] Handle unsafe dynamic components #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vladucu
commented
Jan 25, 2024
•
vladucu
commented
- [breaking] Remove @controlComponent support for PolarisChoiceList
|
✅ Linked to Task AS-395 · [smile-admin] Handle unsafe dynamic components |
vladucu
changed the title
…components This is a merge into main. I created a PR to be reviewed just in case
nahrivera7
requested review from
diegonakamashi
and removed request for
a team
|
This has been review on admin in my local env and everything seems to be working as expected. |
|
@diegonakamashi I'm not sure which step to follow (from the Jira ticket): I tested this by using the last SHA commit in this PR in |
nahrivera7
approved these changes
Feb 7, 2024
diegonakamashi
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.