AS-406 Handle computed-property.override deprecation #76
Conversation
diegonakamashi
requested review from
marianoggf
and removed request for
a team
|
✅ Linked to Task AS-406 · Address Ember 4 deprecations |
diegonakamashi
force-pushed
the
AS-406/computed-property.override
branch
from
01a4b2c
to
1effad1
Compare
| @@ -92,11 +92,19 @@ export default class PolarisDatePicker extends Component { | |||
| * @type {Boolean} | |||
| * @public | |||
| */ | |||
| @computed('selected') | |||
| @computed('selected', '_allowRange') | |||
There was a problem hiding this comment.
nit do we need to depend on _allowRange here? It's just used internally in this CP, or am I wrong?
There was a problem hiding this comment.
🤔 I added the "_allowRange" property here because when we set a new value for allowRange/_allowRange, I expected the locals using the get allowRange method to also be update dto the new value. Am I missing something here?
There was a problem hiding this comment.
Hmm, do you mean this was added so any other property that depends on allowRange to be updated when allowRange changes?
With
@computed('<prop_name>')
get allowRange() {...}you define on which properties it depends. So that for example, if <prop_name> changes, it will trigger updating allowRange.
There was a problem hiding this comment.
Hey @vladucu 👋 , I understood what you mean and remove the property, but now I am getting this lint error:
[lint:js] 95:4 error Use of undeclared dependencies in computed property: _allowRange ember/require-computed-property-dependencies
Should I update the .lint-todo to ignore this error?
There was a problem hiding this comment.
ahh, no...let's just leave that there then. thx for checking
There was a problem hiding this comment.
Looks great so far
I found some cases with the overwritten issue:
- shouldUseSearchEndpoint
- colors-dropdown::ember4845>#options (branding -> theme)
- smile-s3-uploader::ember5857>#fileProcessingOptions (branding -> emails & wallet)
- There are a bunch in the Customer Emails page
There may be more but that's what I found
Hey @marianoggf 👋 , |
|
Just ignore me 😄 |
No description provided.