AS-407 Ember 4 change | Refactor ariaInvalid property #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Task AS-407 · Upgrade to latest Ember 4.x |
nahrivera7
approved these changes
Mar 8, 2024
vladucu
reviewed
Mar 11, 2024
Comment on lines
+358
to
+365
| @computed('error', '_ariaInvalid') | ||
| get ariaInvalid() { | ||
| return this._ariaInvalid ?? !!this.error; | ||
| } | ||
|
|
||
| set ariaInvalid(value) { | ||
| this.set('_ariaInvalid', value); | ||
| } |
There was a problem hiding this comment.
Nice catch fixing this.
Small nit - I think we chatted about this in another PR - but wondering if this simpler form works
@computed('error')
get ariaInvalid() {
return !!this.error;
}
set ariaInvalid(value) {
return value;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are instances where we set
ariaInvalid. For example:However, since it is a boolean computed property, we cannot use this approach in Ember 4 anymore. This PR solves this issue by adding a getter and a setter for
ariaInvalid.