Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Poetry #14

Merged
merged 11 commits into from
Nov 1, 2022
Merged

Migrate to Poetry #14

merged 11 commits into from
Nov 1, 2022

Conversation

vanshg
Copy link
Contributor

@vanshg vanshg commented Oct 31, 2022 •
edited
Loading

Migrate to using Poetry (https://python-poetry.org/docs)

  • Adds support for Python 3.11, released last week
  • Poetry's pyproject.toml file supersedes setup.py, setup.cfg, MANIFEST.in, requirements.txt, dev-requirements.txt
  • Updated README with new instructions
  • Update GitHub Actions to use poetry

mldangelo
mldangelo reviewed Nov 1, 2022
View reviewed changes
Copy link
Contributor

@mldangelo mldangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great work. I left a few nits.

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
mldangelo
mldangelo reviewed Nov 1, 2022
View reviewed changes
Copy link
Contributor

@mldangelo mldangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I'll LGTM as soon as you update the changelog. Thanks a lot @vanshg

smile_id_core/__init__.py Show resolved Hide resolved
@vanshg
Copy link
Contributor Author

vanshg commented Nov 1, 2022

@mldangelo I pinned black to 22.8, so no longer need to drop 3.6 support. Bumped the SDK version to 1.0.9

@vanshg vanshg marked this pull request as ready for review November 1, 2022 16:14
mldangelo
mldangelo approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@mldangelo mldangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vanshg vanshg merged commit 88aea5a into main Nov 1, 2022
@vanshg vanshg deleted the poetry branch November 1, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mldangelo mldangelo mldangelo approved these changes

Assignees

@vanshg vanshg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vanshg @mldangelo