Fix newly added clippy warnings #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
error: the `Err`-variant returned from this function is very large
--> src/tf_broadcaster.rs:45:59
|
45 | pub fn send_transform(&self, tf: TransformStamped) -> Result<(), TfError> {
| ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 136 bytes
|
= note: `-D clippy::result-large-err` implied by `-D warnings`
= help: try reducing the size of `tf_error::TfError`, for example by boxing large elements or replacing it with `Box<tf_error::TfError>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
```
```
error: this block may be rewritten with the `?` operator
--> src/tf_buffer.rs:186:9
|
186 | / if let Err(x) = tf1 {
187 | | return Err(x);
188 | | }
| |_________^ help: replace it with: `tf1?;`
|
= note: `-D clippy::question-mark` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
error: this block may be rewritten with the `?` operator
--> src/tf_buffer.rs:189:9
|
189 | / if let Err(x) = tf2 {
190 | | return Err(x);
191 | | }
| |_________^ help: replace it with: `tf2?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
```
OTL
approved these changes
Dec 2, 2022
| @@ -60,12 +60,12 @@ impl TfIndividualTransformChain { | |||
| if x == 0 { | |||
| return Err(TfError::AttemptedLookupInPast( | |||
| time, | |||
| self.transform_chain.first().unwrap().clone(), | |||
| Box::new(self.transform_chain.first().unwrap().clone()), | |||
There was a problem hiding this comment.
https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
A
Resultis at least as large as theErr-variant. While we expect that variant to be seldomly used, the compiler needs to reserve and move that much memory every single time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.