268 clearing destroyed Xids from NSP state #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far it has only been observed with the st terminal, but it looks like it is possible for a newly spawned window to re-use the Xid of a previous client of the same program. If a NamedScratchpad still thinks it owns a window with that ID it will run the toggle logic under the assumption that the window in question is the one it owned previously. The initial fix for this is to add an event hook that checks for NamedScratchpad clients being destroyed and explicitly removes the stored ID from state. Alternatively we could also look at running the NSP Query every time the toggle binding is run but this feels like a better approach as it keeps the toggle logic as simple as possible.
Closed
2 tasks
sminez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional logging around
NamedScratchpadbehaviour to aide future debugging and putting an event hook in place to clear out destroyed clients. The buggy behaviour has only been observed when using the st terminal as a scratchpad so far and looks to be down to newly created terminal windows sharing an Xid with one that was recently closed.See #268 (comment) for more info.