Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early log message crashes serial logger. #160

Closed
smit-happens opened this issue Apr 23, 2018 · 1 comment
Closed

Early log message crashes serial logger. #160

smit-happens opened this issue Apr 23, 2018 · 1 comment
Assignees
Labels
bug priority-critical Breaks everything, drop everything, get working ASAP wontfix

Comments

@smit-happens
Copy link
Owner

Relevant Info/Links

tested this on @YoungMaker GLCD branch, wasn't working. After messing around with it, it started working
ran it on My PC and @YoungMaker both weren't working, then they both worked

won't fix unless we see it again

@smit-happens smit-happens added this to To Do in SD Logging System via automation Apr 23, 2018
@YoungMaker YoungMaker changed the title Crashing on sd file creation Early log message crashes. Apr 28, 2018
@YoungMaker YoungMaker added the priority-critical Breaks everything, drop everything, get working ASAP label Apr 28, 2018
@YoungMaker YoungMaker changed the title Early log message crashes. Early log message crashes serial logger. Apr 28, 2018
@YoungMaker
Copy link
Collaborator

YoungMaker commented Apr 28, 2018

Currently, we're crashing in the onLogFiled() function in SerialLogger intermittently, esp after a reboot. The length of this message returned by strcpy(message) used in SerialLogger::onLogFiled() is wayy too long for the message given. A current workaround is to remove the SerialLogger message pump call in the msg() function in logger. Possibly could be related to editing memory we're currently using/writing, editing over memory another component immediately uses (such as the SD card logger) or a race condition between two log listeners.

For now, we will continue to use the workaround since the Serial Logger isn't of much use in the car itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug priority-critical Breaks everything, drop everything, get working ASAP wontfix
Projects
None yet
Development

No branches or pull requests

2 participants