Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how the parallax scrolling works #7

Merged
merged 2 commits into from Jul 11, 2022

Conversation

lethal-guitar
Copy link
Contributor

@lethal-guitar lethal-guitar commented Jul 9, 2022

As a follow-up to #6, this adds comments to InitializeBackdropTable, LoadBackdropData, and DrawMapRegion, and renames a few variables.

Also adds an almost novel-sized comment describing the entire parallax scrolling system in detail, as well as an AUTHORS.md file as you suggested in #6.

Let me know what you think - since the explanation is so lengthy, I wasn't sure if you'd maybe prefer to have it outside of the code in a dedicated file, or if you think it's fine like this.

@lethal-guitar lethal-guitar force-pushed the explain-parallax branch 3 times, most recently from 252f069 to 968e23b Compare July 9, 2022 19:56
Add comments to LoadBackdropData, InitializeBackdropTable, and
DrawMapRegion. Also rename a few variables, and add some
@smitelli
Copy link
Owner

Looking good! 👍 I saw you pushed recently; let me know when you're ready for the final review and I'll merge then.

As for the lengthiness of the comments, not a problem here -- look at lowlevel.asm for example. 😁 Eventually, I might incorporate/move some of the commentary from here to Cosmodoc, my other perpetually unfinished project. If that happens, I'll be sure to acknowledge your work accordingly.

@lethal-guitar
Copy link
Contributor Author

Looking good! 👍 I saw you pushed recently; let me know when you're ready for the final review and I'll merge then.

Yeah I had noticed a few small mistakes when re-reading the comments and fixed those. But it should be ready now!

As for the lengthiness of the comments, not a problem here -- look at lowlevel.asm for example. 😁 Eventually, I might incorporate/move some of the commentary from here to Cosmodoc, my other perpetually unfinished project. If that happens, I'll be sure to acknowledge your work accordingly.

Great, sounds good! 👍🏻

@smitelli
Copy link
Owner

Many, many thanks for your efforts!

@smitelli smitelli merged commit e68432e into smitelli:main Jul 11, 2022
@lethal-guitar lethal-guitar deleted the explain-parallax branch July 11, 2022 13:45
@lethal-guitar
Copy link
Contributor Author

lethal-guitar commented Jul 11, 2022

@smitelli it's my pleasure! 🙂 Thanks for making Cosmore, it inspired me to attempt doing something similar for Duke Nukem II. Sort of as a complement to RigelEngine, since its code is extremely different from what the original might have looked like in many aspects, even if the resulting behavior is the same. It's still in the early stages right now, but Cosmore definitely was a great help in getting it off the ground!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants