All Quantified Peaks Reader #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #788 +/- ##
==========================================
+ Coverage 75.38% 75.43% +0.04%
==========================================
Files 199 201 +2
Lines 30655 30716 +61
Branches 3079 3086 +7
==========================================
+ Hits 23110 23171 +61
Misses 7026 7026
Partials 519 519
|
nbollis
added
ready for final review / merge
ready for review
and removed
WIP
ready for final review / merge
labels
trishorts
previously approved these changes
Jul 12, 2024
elaboy
previously approved these changes
Jul 15, 2024
elaboy
approved these changes
Jul 23, 2024
Alexander-Sol
approved these changes
Jul 23, 2024
trishorts
approved these changes
Jul 23, 2024
elaboy
pushed a commit
to elaboy/mzLib-Fork
that referenced
this pull request
Aug 5, 2024
* Added in a file to read all quantified peaks into readers and wrote initial tests * expanded test coverage * changed ms2retention time to nullable so that mbr peaks do not break the reader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in a class to read in our all quantified peaks output from FlashLFQ