Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fillup creates intervals on holidays if the holidays fall on a weekend #67

Closed
smithfarm opened this issue Jan 24, 2016 · 1 comment
Closed
Assignees
Labels

Comments

@smithfarm
Copy link
Owner

Take the following hypothetical schedule:

FRI 08:00-12:00, 12:30-16:30
SAT 08:00-12:00, 12:30-16:30
SUN 08:00-12:00, 12:30-16:30

and do a fillup over the tsrange [ 1960-12-22 00:00, 1960-12-26 24:00 ) i.e. Thu-Mon, where Sat, Sun, and Mon are holidays.

The result is mystifying: intervals are successfully created on all three days according to the schedule.

@smithfarm smithfarm added the bug label Jan 24, 2016
@smithfarm smithfarm self-assigned this Jan 24, 2016
@smithfarm
Copy link
Owner Author

And the culprit is . . . holidays_in_daterange()!

[Sun Jan 24 21:09:38 2016] DEBUG: fillup_tempintvls(): holidays_in_daterange says $VAR1 = {
          '1960-12-26' => ''
        };

smithfarm added a commit that referenced this issue Jan 24, 2016
#67 References: #67

Signed-off-by: Nathan Cutler <ncutler@suse.com>
smithfarm added a commit that referenced this issue Jan 24, 2016
#67 References: #67

Signed-off-by: Nathan Cutler <ncutler@suse.com>
smithfarm added a commit that referenced this issue Jan 24, 2016
Employees may have work scheduled on weekends. If holidays_in_daterange()
ignored holidays that fall on weekends, employees using fillup will get
work intervals that fall on holidays.

#67 Fixes: #67

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm smithfarm mentioned this issue Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant