Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

80/fix inclusive flag #81

Merged
merged 4 commits into from
May 11, 2020
Merged

80/fix inclusive flag #81

merged 4 commits into from
May 11, 2020

Conversation

junkert
Copy link
Collaborator

@junkert junkert commented May 10, 2020

This should fix the issue with --inclusive missing from the process command from the cli. See #80

@junkert
Copy link
Collaborator Author

junkert commented May 10, 2020

Coverage went down with this addition. Testing would require us to add Viper testing which has not been added yet and is outside of the scope of this bugfix.

@junkert junkert self-assigned this May 10, 2020
@junkert junkert added the bug Something isn't working label May 10, 2020
generator.go Outdated Show resolved Hide resolved
Copy link
Contributor

@wavemoran wavemoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@junkert junkert merged commit 3dbd3c2 into master May 11, 2020
@junkert junkert deleted the 80/fix-inclusive-flag branch May 11, 2020 19:20
@junkert
Copy link
Collaborator Author

junkert commented May 11, 2020

I have tagged this release as v1.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants