Update to use empty list instead of new property

examples/jar-plugin/custom-trait/consumer/build.gradle.kts

@@ -17,5 +17,5 @@ dependencies {
 }
 
 smithy {
-    noBuildConfig.set(true)
+    smithyBuildConfigs.set(project.files())
 }

examples/jar-plugin/multi-project/consumer/build.gradle.kts

@@ -6,7 +6,3 @@ dependencies {
     implementation(project(":producer1"))
     implementation(project(":producer2"))
 }
-
-smithy {
-    noBuildConfig.set(true)
-}

examples/jar-plugin/multi-project/consumer/smithy-build.json

@@ -0,0 +1,3 @@
+{
+  "version": "1.0"
+}

smithy-base/src/it/java/software/amazon/smithy/gradle/ForbidImplicitNoBuildConfigTest.java

@@ -16,7 +16,7 @@ public void testExceptionThrows() {
                     .buildAndFail();
 
             Assertions.assertTrue(result.getOutput()
-                    .contains("No smithy-build configs found. If this was intentional, set the `noBuildConfigs` flag to `true`."));
+                    .contains("No smithy-build configs found. If this was intentional, set the `smithyBuildConfigs` property to an empty list."));
             Utils.assertArtifactsNotCreated(buildDir,
                     "build/smithyprojections/forbid-implicit-no-build-config/source/build-info/smithy-build-info.json");
         });

smithy-base/src/main/java/software/amazon/smithy/gradle/SmithyBasePlugin.java

@@ -195,7 +195,6 @@ private TaskProvider<SmithyBuildTask> addBuildTaskForSourceSet(SourceSet sourceS
                             build.getSmithyBuildConfigs().set(extension.getSmithyBuildConfigs());
                             build.getSourceProjection().set(extension.getSourceProjection());
                             build.getProjectionSourceTags().set(extension.getProjectionSourceTags());
-                            build.getNoBuildConfig().set(extension.getNoBuildConfig());
                             build.getOutputDir().set(extension.getOutputDirectory());
 
                             // Add smithy configurations as classpaths for build task

smithy-base/src/main/java/software/amazon/smithy/gradle/SmithyExtension.java

@@ -54,10 +54,8 @@ private void configureDefaults(Project project) {
         getSourceProjection().convention(SMITHY_SOURCE_PROJECTION_DEFAULT);
         getFork().convention(false);
         getFormat().convention(true);
-        getNoBuildConfig().convention(false);
         getAllowUnknownTraits().convention(false);
         getOutputDirectory().convention(getDefaultOutputDirectory(project));
-
     }
 
     /**
@@ -144,17 +142,6 @@ public NamedDomainObjectContainer<SmithySourceDirectorySet> getSourceSets() {
      */
     public abstract Property<Boolean> getFork();
 
-    /**
-     * Gets whether unknown traits in the model should be ignored.
-     *
-     * <p>By default, the build will fail if no config is provided.
-     * This can be set to true to allow the build task to execute
-     * with an empty config when no smithy-build config is provided.
-     *
-     * @return Returns true if no config should be provided.
-     */
-    public abstract Property<Boolean> getNoBuildConfig();
-
     /**
      * Gets the output directory for running Smithy build.
      *

smithy-base/src/main/java/software/amazon/smithy/gradle/tasks/SmithyBuildTask.java

@@ -39,7 +39,6 @@ public SmithyBuildTask(ObjectFactory objectFactory) {
         super(objectFactory);
 
         getSourceProjection().convention("source");
-        getNoBuildConfig().convention(false);
         getOutputDir().convention(SmithyUtils.getProjectionOutputDirProperty(getProject()));
     }
 
@@ -68,17 +67,6 @@ public SmithyBuildTask(ObjectFactory objectFactory) {
     @InputFiles
     public abstract Property<FileCollection> getSmithyBuildConfigs();
 
-    /**
-     * Sets whether to allow the build to continue if no build config is set.
-     *
-     * <p> Defaults to false.
-     *
-     * @return flag indicating if build should continue if no build configs are found.
-     */
-    @Input
-    @Optional
-    public abstract Property<Boolean> getNoBuildConfig();
-
     /**
      * Sets whether to fail a {@link SmithyBuildTask} if an unknown trait is encountered.
      *
@@ -124,14 +112,20 @@ List<String> getModelAbsolutePaths() {
      * @return Returns true if at least one of the specified build configs exists.
      */
     @Internal
-    Provider<Boolean> getSmithyBuildConfigsExist() {
-        return getSmithyBuildConfigs().map(files -> !files.filter(File::exists).isEmpty());
+    Provider<Boolean> getSmithyBuildConfigsMissing() {
+        return getSmithyBuildConfigs().map(
+                files -> !files.isEmpty() && files.filter(File::exists).isEmpty()
+        );
     }
 
     @TaskAction
     public void execute() {
         writeHeading("Running smithy build");
-        validateBuildConfigs();
+
+        if (getSmithyBuildConfigsMissing().get()) {
+            throw new GradleException("No smithy-build configs found. "
+                    + "If this was intentional, set the `smithyBuildConfigs` property to an empty list.");
+        }
 
         BuildParameterBuilder builder = new BuildParameterBuilder();
 
@@ -164,13 +158,4 @@ public void execute() {
                 getFork().get()
         );
     }
-
-    private void validateBuildConfigs() {
-        // If none of the specified Smithy build configs exist and
-        // the `noBuildConfigs` flag is false then throw an error
-        if (!getSmithyBuildConfigsExist().get() && !getNoBuildConfig().get()) {
-            throw new GradleException("No smithy-build configs found. "
-                    + "If this was intentional, set the `noBuildConfigs` flag to `true`.");
-        }
-    }
 }