-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SmithyExtension
options are not correctly modeled as task inputs
#72
Comments
Encountered a situation where this specifically impacted me, was able to work around it via:
|
brandondahler
pushed a commit
to brandondahler/smithy-gradle-plugin
that referenced
this issue
Apr 6, 2023
Configures the tasks to have their first configuration action to be copying the value from the extension to the task.
brandondahler
pushed a commit
to brandondahler/smithy-gradle-plugin
that referenced
this issue
Apr 6, 2023
Configures the tasks to have their first configuration action to be copying the value from the extension to the task.
hpmellema
pushed a commit
that referenced
this issue
Apr 12, 2023
The 0.8.0 release to has updated plugin tasks correctly model task inputs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
SmithyBuildJar
task runs the following code at execution time (i.e. inSmithyBuildJar::execute
):This is effectively an unmodeled task input and is therefore incorrect. It can cause Gradle to skip this task entirely, or to fail to evaluate a lazy file collection provided to the extension as an input. To fix this, you either have to share the same
FileCollection
instance betweenSmithyExtension
andSmithyBuildJar
, or you have to return both instances as@InputFiles
fromSmithyBuildJar
.The text was updated successfully, but these errors were encountered: