Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move validate task to base plugin #133

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Move validate task to base plugin #133

merged 1 commit into from
Mar 19, 2024

Conversation

hpmellema
Copy link
Contributor

Background

  • Moves the validate task to the base plugin and changes the Sources property to be Sources instead of JarToValidate as this task could be used to validate any set of smithy sources.
  • The validate task is more generally useful that just for validating a JAR file in the smithy-jar plugin. Eventually we plan to add validation reports to this task which might be added as part of the base plugin. Because this task can be used outside of a jar context it should not live in the smithy-jar plugin.

Testing

  • Executed integration tests which already test validation capability

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hpmellema hpmellema requested a review from a team as a code owner March 19, 2024 15:05
@hpmellema hpmellema merged commit 86186ad into main Mar 19, 2024
4 checks passed
@hpmellema hpmellema deleted the move-validate-task branch March 19, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants