Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serde interface hygiene #314

Open
aajtodd opened this issue May 6, 2021 · 0 comments
Open

serde interface hygiene #314

aajtodd opened this issue May 6, 2021 · 0 comments
Labels
no-auto-closure We do not want this issue to be automatically closed. refactor
Milestone
M6

Comments

@aajtodd
Copy link
Contributor

aajtodd commented May 6, 2021

Why are map and struct serializers inheriting PrimitiveSerializer? Both of these have their own API (e.g. field(...) and entry(...) and I don’t think they need to inherit this but unsure).

Also StructSerializer has method structField(...) on it that I'm not sure we actually ever use or codegen anything for.

Task here is to investigate and cleanup some of these API's.
@aajtodd aajtodd added this to the M4 milestone Jun 10, 2021
@aajtodd aajtodd modified the milestones: M4, M6 Sep 27, 2021
@ianbotsf ianbotsf added the no-auto-closure We do not want this issue to be automatically closed. label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-auto-closure We do not want this issue to be automatically closed. refactor
Projects
None yet
Milestone
M6
Development

No branches or pull requests
2 participants
@aajtodd @ianbotsf