Refactor hover and definition tests #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
We should create a test-utils package or something one day to make it easier to create and maintain JARs like this for tests.
| import org.eclipse.lsp4j.Range; | ||
| import software.amazon.smithy.lsp.ext.SmithyProjectTest; | ||
|
|
||
| import static org.junit.Assert.assertTrue; |
There was a problem hiding this comment.
Not necessary, but FYI you can actually make custom JUnit assertions. See for example https://github.com/smithy-lang/smithy/blob/main/smithy-model/src/test/java/software/amazon/smithy/model/ShapeMatcher.java
There was a problem hiding this comment.
I'd like to move the language server to hamcrest and junit5 like the Smithy repo, maybe this can be a part of that. Seems useful
milesziemer
force-pushed
the
refactor-tds-tests
branch
3 times, most recently
from
dd6418d
to
5437eb5
Compare
- Moves tests for hover and definition into their own test files. - Refactors Harness to use a builder instead of overloaded `create` methods, and updates other tests to use the builder. - Moves StubClient into its own file to be used by hover and definition tests. - Adds TestUtils class to house common methods used by tests. - Adds `setProject` method to SmithyTextDocumentService for usage by tests. Eventually I think we can simplify the v1 vs v2 tests more since some of them are shared, and make these kinds of tests parameterized with junit5.
milesziemer
force-pushed
the
refactor-tds-tests
branch
from
5437eb5
to
1a61744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createmethods, and updates other tests to use the builder.setProjectmethod to SmithyTextDocumentService for usage by tests.Eventually I think we can simplify the v1 vs v2 tests more since some of them are shared, and make these kinds of tests parameterized with junit5.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.