Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor the default trait #1860

Closed
david-perez opened this issue Oct 17, 2022 · 4 comments
Closed

Honor the default trait #1860

david-perez opened this issue Oct 17, 2022 · 4 comments
Labels
client

Comments

@david-perez
Copy link
Contributor

Neither clients or servers are honoring the default trait from IDL v2. This trait affects serialization behavior of clients and servers.

Note that as far as I know, awslabs/smithy does not yet provide protocol tests exercising this trait, so we may have to write our own and contribute them upstream.
@david-perez david-perez added the bug Something isn't working label Oct 17, 2022
@jdisanti
Copy link
Collaborator

I think only the server needs to implement this. The clients aren't supposed to send the default value since changing the default is not a backwards breaking change.

82marbag added a commit that referenced this issue Oct 19, 2022
@82marbag
Support @default
40d8625 
Add support for the @default trait.

Issue: #1860
Reference for the trait:
https://awslabs.github.io/smithy/2.0/spec/type-refinement-traits.html

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
@82marbag 82marbag mentioned this issue Oct 19, 2022
Merged
2 tasks
82marbag added a commit that referenced this issue Oct 20, 2022
@82marbag
Support @default
6e45344 
Add support for the @default trait.

Issue: #1860
Reference for the trait:
https://awslabs.github.io/smithy/2.0/spec/type-refinement-traits.html

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
@82marbag
Copy link
Contributor

PR failing pending more info on smithy-lang/smithy#1456

82marbag added a commit that referenced this issue Nov 3, 2022
@82marbag
Support @default
02e2599 
Add support for the @default trait.

Issue: #1860
Reference for the trait:
https://awslabs.github.io/smithy/2.0/spec/type-refinement-traits.html

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
@82marbag 82marbag added server Rust server SDK client and removed bug Something isn't working labels Dec 23, 2022
@82marbag 82marbag removed the server Rust server SDK label Feb 27, 2023
@82marbag
Copy link
Contributor

Leaving this open for the client implementation

@jdisanti
Copy link
Collaborator

jdisanti commented Apr 5, 2024

I believe the client does this correctly now.

@jdisanti jdisanti closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdisanti @david-perez @82marbag