Use the SymbolProvider and Model directly from the Smithy plugins
#1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
rcoh
reviewed
Jun 3, 2022
| @@ -36,8 +35,6 @@ class ServerAwsJsonFactory(private val version: AwsJsonVersion) : ProtocolGenera | |||
| override fun buildProtocolGenerator(codegenContext: CodegenContext): ServerHttpBoundProtocolGenerator = | |||
| ServerHttpBoundProtocolGenerator(codegenContext, protocol(codegenContext)) | |||
|
|
|||
| override fun transformModel(model: Model): Model = model | |||
There was a problem hiding this comment.
I used this yesterday to augment the S3 model with some extra metadata—I think we should keep these, especially since the default implementation means that there isn't any cost to having it
There was a problem hiding this comment.
You used the transformModel from the decorators, not this one. I accidentally removed the invocation of the former, but I didn't mean to, that's why CI failed. I've now fixed that.
Despite all the decorators and protocols that we have, there aren't any `RustCodegenDecorator`s or `ProtocolGeneratorFactory`s that are modifying the base symbol provider that the Smithy plugin provides. So we can use directly the base symbol provider everywhere and remove the methods from these interfaces to make the code a little bit simpler. Likewise, there isn't a single `ProtocolGeneratorFactory` that transforms the base model that the Smithy plugin provides.
david-perez
force-pushed
the
davidpz/use-the-_symbolprovider_-and-_model_-directly-from-the-smithy-plugins
branch
from
689be8f
to
862f073
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
82marbag
reviewed
Jun 9, 2022
| import software.amazon.smithy.rust.codegen.smithy.generators.LibRsCustomization | ||
| import software.amazon.smithy.rust.codegen.smithy.generators.ManifestCustomizations | ||
| import software.amazon.smithy.rust.codegen.smithy.generators.client.FluentClientDecorator | ||
| import software.amazon.smithy.rust.codegen.smithy.generators.config.ConfigCustomization | ||
| import software.amazon.smithy.rust.codegen.smithy.protocols.ProtocolMap | ||
| import software.amazon.smithy.rust.codegen.util.deepMergeWith | ||
| import java.util.ServiceLoader | ||
| import java.util.* |
There was a problem hiding this comment.
Why hasn't the linter complained about *?
82marbag
approved these changes
Jun 9, 2022
…mbolprovider_-and-_model_-directly-from-the-smithy-plugins
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
…-directly-from-the-smithy-plugins
rcoh
approved these changes
Jun 9, 2022
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
crisidev
approved these changes
Jun 10, 2022
…mbolprovider_-and-_model_-directly-from-the-smithy-plugins
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
…mbolprovider_-and-_model_-directly-from-the-smithy-plugins
david-perez
force-pushed
the
davidpz/use-the-_symbolprovider_-and-_model_-directly-from-the-smithy-plugins
branch
from
f59b6e3
to
a0dd263
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
deleted the
davidpz/use-the-_symbolprovider_-and-_model_-directly-from-the-smithy-plugins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite all the decorators and protocols that we have, there aren't any
RustCodegenDecorators orProtocolGeneratorFactorys that aremodifying the base symbol provider that the Smithy plugin provides. So
we can use directly the base symbol provider everywhere and remove the
methods from these interfaces to make the code a little bit simpler.
Likewise, there isn't a single
ProtocolGeneratorFactorythattransforms the base model that the Smithy plugin provides.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.