Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to generate pub(crate) values #1444

Merged
merged 5 commits into from
Jun 9, 2022
Merged

Conversation

david-perez
Copy link
Contributor

A small commit adding the ability to generate pub(crate) values.
Currently we don't need to, but this is used in #1342. It's also nicer
to use an enum instead of passing around a boolean.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

A small commit adding the ability to generate `pub(crate)` values.
Currently we don't need to, but this is used in #1342. It's also nicer
to use an enum instead of passing around a boolean.
@david-perez david-perez requested review from a team as code owners June 6, 2022 18:10
@david-perez
Copy link
Contributor Author

This is primarily to make the diff of #1342 lighter.

@david-perez david-perez mentioned this pull request Jun 6, 2022
@smithy-lang smithy-lang deleted a comment from github-actions bot Jun 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -5.78% 39632.98 42065.57
Total requests -5.80% 3568772 3788657
Total errors NaN% 0 0
Total successes -5.80% 3568772 3788657
Average latency ms 3.70% 0.84 0.81
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 5.70% 18.72 17.71
Stdev latency ms -4.76% 0.6 0.63
Transfer Mb -5.80% 370.98 393.83
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

Copy link
Contributor

@crisidev crisidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@david-perez david-perez merged commit 336c1a2 into main Jun 9, 2022
@david-perez david-perez deleted the davidpz/pubcrate branch June 9, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants