Add server side HTTP logging layer #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
Jul 27, 2022
| ) | ||
|
|
||
| // Models the ways headers can be bound and sensitive | ||
| sealed class HeaderSensitivity( |
There was a problem hiding this comment.
What does bound mean in this context?
...ftware/amazon/smithy/rust/codegen/server/smithy/generators/ServerHttpSensitivityGenerator.kt
Show resolved
Hide resolved
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
crisidev
approved these changes
Jul 30, 2022
Comment on lines
+98
to
+100
| fn make_display(&self, source: T) -> Self::Target { | ||
| U::make(self, source) | ||
| } |
There was a problem hiding this comment.
I think it's fine to leave it like it is. It was NIT anyway :)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#1536
Description
MakeFmttrait which modifiesDisplay/Debugimplementations.httpwrappers which modify theDebugandDisplayimplementations based on closures marking sensitivity. Each wrapper has an associatedMakeFmtimpl.InstrumentOperationtower::Service which logs requests and responses. Accepts aMakeFmtfor each potentially sensitive component of the request/response.InstrumentationOperationto theOperationHandlerusingMakeFmts using the marker closures.