Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in WriteGetObjectResponse endpoint #2560

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Apr 10, 2023

Motivation and Context

Description

We erroneously followed a broken endpoint test for WriteGetObject response and dropped the hostPrefix trait.
This:

  • ignores the test instead
  • brings back host prefix
  • adds a handwritten test verifying correct behavior

Testing

  • UT

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@rcoh rcoh added the next-release fixes / updates that need to be merged prior to release label Apr 10, 2023
@rcoh rcoh enabled auto-merge April 10, 2023 15:22
@rcoh rcoh added this pull request to the merge queue Apr 10, 2023
Merged via the queue into main with commit ee324f2 Apr 10, 2023
@rcoh rcoh deleted the fix-write-get-object-response-request-route branch April 10, 2023 15:49
rcoh added a commit that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release fixes / updates that need to be merged prior to release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants