Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs no credentials #3279

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Improve docs no credentials #3279

merged 2 commits into from
Dec 1, 2023

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Dec 1, 2023 •
edited
Loading

Motivation and Context

Description

Add documentation to no_credentials and add test_credentials() method

Testing

CI

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh force-pushed the improve-docs-no-credentials branch from db1d3ff to aee7d3c Compare December 1, 2023 17:25
@rcoh rcoh force-pushed the improve-docs-no-credentials branch from aee7d3c to 5a77543 Compare December 1, 2023 17:26
@rcoh rcoh marked this pull request as ready for review December 1, 2023 17:27
@rcoh rcoh requested review from a team as code owners December 1, 2023 17:27
jdisanti
jdisanti approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@jdisanti jdisanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

CHANGELOG.next.toml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@rcoh @jdisanti
Update CHANGELOG.next.toml
25fdf25 
Co-authored-by: John DiSanti <jdisanti@amazon.com>
@rcoh rcoh enabled auto-merge December 1, 2023 20:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@rcoh rcoh added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 2cac4d7 Dec 1, 2023
41 checks passed
@rcoh rcoh deleted the improve-docs-no-credentials branch December 1, 2023 21:51
@jdisanti jdisanti mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdisanti jdisanti jdisanti approved these changes

@ysaito1001 ysaito1001 ysaito1001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rcoh @jdisanti @ysaito1001