create an IdentityCache by default when on latest BehaviorVersion #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Base automatically changed from
jdisanti-bmv-stall-uploads
to
behavior-version-2024-03-28
April 24, 2024 19:20
aajtodd
force-pushed
the
atodd/bmv-identity-cache
branch
from
0834574
to
83290df
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
reviewed
Apr 25, 2024
| @@ -238,14 +239,14 @@ mod loader { | |||
| use crate::provider_config::ProviderConfig; | |||
|
|
|||
| #[derive(Default, Debug)] | |||
| enum CredentialsProviderOption { | |||
| /// No provider was set by the user. We can set up the default credentials provider chain. | |||
| enum TriStateOption<T> { | |||
There was a problem hiding this comment.
We used to have a TriState in aws-smithy-types. You could consider resurrecting that if you want to, but doesn't matter to me either way since this is private.
There was a problem hiding this comment.
If we have need for another tri-state then we can move it but for now I think I'd keep it private.
| /// .await; | ||
| /// # } | ||
| /// ``` | ||
| pub fn no_identity_cache(mut self) -> Self { |
There was a problem hiding this comment.
Does this behave differently from loader.identity_cache(IdentityCache::no_cache())?
There was a problem hiding this comment.
Yes. IdentityCache::no_cache() is still an explicit cache being set whereas no_identity_cache() leaves it as "explicitly unset" so as to not enable the default cache. Open to bikeshedding on naming and how to best avoid confusion here.
There was a problem hiding this comment.
Discussed offline and decided to remove this API for now as it can always be added later and users can still control this by setting a different cache per/client.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Apr 26, 2024
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 2, 2024
## Motivation and Context This PR is the combination of two previously reviewed PRs that both enable new behaviors behind a new Behavior Major Version (BMV): * #3527 * #3578 ## Description * Enables stalled stream protection by default on latest behavior version. * Enables creation of a default identity cache. ## Testing All testing done on prior PRs. See for details. ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: John DiSanti <jdisanti@amazon.com> Co-authored-by: ysaito1001 <awsaito@amazon.com>
ogghead
pushed a commit
to ogghead/smithy-rs
that referenced
this pull request
May 5, 2024
This PR is the combination of two previously reviewed PRs that both enable new behaviors behind a new Behavior Major Version (BMV): * smithy-lang#3527 * smithy-lang#3578 * Enables stalled stream protection by default on latest behavior version. * Enables creation of a default identity cache. All testing done on prior PRs. See for details. <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: John DiSanti <jdisanti@amazon.com> Co-authored-by: ysaito1001 <awsaito@amazon.com>
aws-sdk-rust-ci
pushed a commit
to awslabs/aws-sdk-rust
that referenced
this pull request
May 8, 2024
## Motivation and Context This PR is the combination of two previously reviewed PRs that both enable new behaviors behind a new Behavior Major Version (BMV): * smithy-lang/smithy-rs#3527 * smithy-lang/smithy-rs#3578 ## Description * Enables stalled stream protection by default on latest behavior version. * Enables creation of a default identity cache. ## Testing All testing done on prior PRs. See for details. ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: John DiSanti <jdisanti@amazon.com> Co-authored-by: ysaito1001 <awsaito@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Original issue: #3427
RFC: #3544
Description
Make
ConfigLoadercreate anIdentityCacheby default when on the latestBehaviorVersion. This will allow SDK clients created fromSdkConfigto share a cache by default instead of creating one per/client.Checklist
CHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.