Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: default features from runtime crates #935

Merged
merged 17 commits into from
Dec 8, 2021

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented Dec 6, 2021

Motivation and Context

This PR addresses #930

Description

This PR modifies runtime crates to have no default features. The desired features must now be explicitly defined and many tests and examples have been updated to specify the features they require.

Testing

I ran the CI tests/lints

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

update: tests and examples broken by default feature change
update: code generation broken by default feature change
fix: follow lint suggestion to lowercase variable names
@Velfi Velfi requested a review from a team as a code owner December 6, 2021 22:59
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

A new generated diff is ready to view.

Copy link
Collaborator

@jdisanti jdisanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start!

fix: typo
formatting: sort imports
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

A new generated diff is ready to view.

…on a runtime crate

update: undo default feature change for SDK
fix: tests broken by default feature change
fix: examples broken by default feature change
@Velfi Velfi requested a review from a team as a code owner December 7, 2021 16:14
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new generated diff is ready to view.

add: doc w/ feature grid to aws-smithy-client
add: doc w/ feature grid to aws-smithy-http
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new doc preview is ready to view.

CHANGELOG.next.toml Outdated Show resolved Hide resolved
CHANGELOG.next.toml Outdated Show resolved Hide resolved
aws/rust-runtime/aws-http/Cargo.toml Outdated Show resolved Hide resolved
rust-runtime/aws-smithy-client/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@crisidev crisidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the server runtime perspective.

undo: bad formatting
formatting: add backticks to feature names in doc table
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new doc preview is ready to view.

formatting: update CHANGELOG.next.toml
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new doc preview is ready to view.

rename: feature "bytestream-util" to "rt-tokio"
update: mark "tower" dep as non-optional in SDKs
docs: update aws-smithy-http docs and README.md
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new generated diff is ready to view.

Copy link
Collaborator

@jdisanti jdisanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really close! Just some minor comments/question.

CHANGELOG.next.toml Outdated Show resolved Hide resolved
aws/rust-runtime/aws-sigv4/Cargo.toml Outdated Show resolved Hide resolved
aws/rust-runtime/aws-types/Cargo.toml Outdated Show resolved Hide resolved
rust-runtime/aws-smithy-http/README.md Outdated Show resolved Hide resolved
Co-authored-by: John DiSanti <jdisanti@amazon.com>
Co-authored-by: John DiSanti <jdisanti@amazon.com>
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new doc preview is ready to view.

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new doc preview is ready to view.

update: CHANGELOG.next.toml
remove: rt-tokio dep feature for aws-smithy-async usage in aws-types
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

A new doc preview is ready to view.

@Velfi Velfi enabled auto-merge (squash) December 8, 2021 16:34
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

A new doc preview is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

A new generated diff is ready to view.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

A new doc preview is ready to view.

@Velfi Velfi merged commit b5f53be into main Dec 8, 2021
@Velfi Velfi deleted the remove/default_features_from_runtime_crates branch December 8, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants