-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove: default features from runtime crates #935
Conversation
update: tests and examples broken by default feature change update: code generation broken by default feature change fix: follow lint suggestion to lowercase variable names
A new generated diff is ready to view.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start!
aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/AwsFluentClientDecorator.kt
Outdated
Show resolved
Hide resolved
aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/AwsFluentClientDecorator.kt
Outdated
Show resolved
Hide resolved
fix: typo formatting: sort imports
A new generated diff is ready to view.
|
…on a runtime crate update: undo default feature change for SDK fix: tests broken by default feature change fix: examples broken by default feature change
A new doc preview is ready to view. |
A new generated diff is ready to view.
|
add: doc w/ feature grid to aws-smithy-client add: doc w/ feature grid to aws-smithy-http
A new generated diff is ready to view.
|
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the server runtime perspective.
undo: bad formatting formatting: add backticks to feature names in doc table
A new generated diff is ready to view.
|
A new doc preview is ready to view. |
formatting: update CHANGELOG.next.toml
A new generated diff is ready to view.
|
A new doc preview is ready to view. |
rename: feature "bytestream-util" to "rt-tokio" update: mark "tower" dep as non-optional in SDKs docs: update aws-smithy-http docs and README.md
A new doc preview is ready to view. |
A new generated diff is ready to view.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really close! Just some minor comments/question.
Co-authored-by: John DiSanti <jdisanti@amazon.com>
Co-authored-by: John DiSanti <jdisanti@amazon.com>
A new generated diff is ready to view.
|
A new doc preview is ready to view. |
A new generated diff is ready to view.
|
A new generated diff is ready to view.
|
A new doc preview is ready to view. |
1 similar comment
A new doc preview is ready to view. |
update: CHANGELOG.next.toml remove: rt-tokio dep feature for aws-smithy-async usage in aws-types
A new doc preview is ready to view. |
A new generated diff is ready to view.
|
codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/EventStreamSymbolProvider.kt
Outdated
Show resolved
Hide resolved
A new doc preview is ready to view. |
A new generated diff is ready to view.
|
…ovider.kt fix: incorrect doc comment
A new generated diff is ready to view.
|
A new doc preview is ready to view. |
A new doc preview is ready to view. |
A new generated diff is ready to view.
|
A new generated diff is ready to view.
|
A new doc preview is ready to view. |
Motivation and Context
This PR addresses #930
Description
This PR modifies runtime crates to have no default features. The desired features must now be explicitly defined and many tests and examples have been updated to specify the features they require.
Testing
I ran the CI tests/lints
Checklist
CHANGELOG.next.toml
if I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.toml
if I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.