remove aws-hyper #959
Merged
remove aws-hyper #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
|
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
|
rcoh
changed the title
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new doc preview is ready to view. |
Velfi
reviewed
Dec 13, 2021
| of `aws_smithy_client::Client` with the middleware type preset. | ||
|
|
||
| _Note:_ this crate will be removed in the future in favor of defining the middlewares directly in the service clients. | ||
| This crate has been removed. Middleware is now defined on a per-service basis. |
There was a problem hiding this comment.
Nice of you to leave a tombstone 🙂
Velfi
reviewed
Dec 13, 2021
Velfi
approved these changes
Dec 13, 2021
|
A new generated diff is ready to view.
|
|
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0006_service_specific_middleware.md
Fixes #934
Description
This moves the middleware defined in aws-hyper into aws-inlineable which allows each service to generate it's own middleware. Although this is not currently customized, it will be customized in the future by services such as S3 to bring a custom endpoint resolver.
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.