client destroy method will call SmithyClient destroy by default #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
approved these changes
Apr 7, 2020
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
* client destroy method will call SmithyClient destroy by default * move calling default detroy after other customizations destroy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all the clientRuntimeCustomization can have a
destroy()function. But the default configs in smithy client doesn't have one.This change will make the service client call the
destroy()from smithy client. By default theSmithyClient.destroy()is an empty function. But if therequestHandlerin SmithyClient has adestroy, service client will call the function when callling the destroy on the service client.Related: aws/aws-sdk-js-v3#1081
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.