-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding pagination to codegen #200
Merged
kstich
merged 16 commits into
smithy-lang:master
from
alexforsyth:alexforsyth/pagination
Aug 21, 2020
Merged
feat: adding pagination to codegen #200
kstich
merged 16 commits into
smithy-lang:master
from
alexforsyth:alexforsyth/pagination
Aug 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexforsyth
commented
Aug 17, 2020
...pescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CodegenVisitor.java
Outdated
Show resolved
Hide resolved
alexforsyth
commented
Aug 17, 2020
...pescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CodegenVisitor.java
Outdated
Show resolved
Hide resolved
For reference: When this is run on the test (ListCities) this will generate this paginator file:
|
This will also generate this interface:
|
To make this work, a customer would need to write:
|
alexforsyth
commented
Aug 17, 2020
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
kstich
requested changes
Aug 20, 2020
...pescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CodegenVisitor.java
Outdated
Show resolved
Hide resolved
...pescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/IndexGenerator.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
alexforsyth
changed the title
WIP: Alexforsyth/pagination
feat: adding pagination to codegen
Aug 20, 2020
kstich
reviewed
Aug 20, 2020
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
kstich
approved these changes
Aug 21, 2020
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
This commit adds support for generating a paginator abstraction for service operations with the `@paginated` trait applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding Pagination code generation.
Please be kind! This is basically the first time i've touched java code since ?highschool?. Please let me know what to change - im sure i'm missing lots of obvious stuff.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.