Check for only structure shapes for circular dependency #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
requested changes
Feb 26, 2021
...-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructuredMemberWriter.java
Show resolved
Hide resolved
trivikr
force-pushed
the
fix-filterSensitiveLog-recursion-bug
branch
from
09557c4
to
f0e2aad
Compare
trivikr
changed the title
|
LGTM - i'll leave approval to @kstich |
AllanZhengYP
approved these changes
Mar 4, 2021
kstich
approved these changes
Mar 4, 2021
gosar
pushed a commit
that referenced
this pull request
Mar 18, 2021
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
The Set
parentswas added to avoid StackOverflow Error occurring due to circular dependencies in recursion in PR #181To check for recursions, the value needs to be populated only for Structure shapes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.