Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties for controlling JReleaser configurations #2330

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

haydenbaker
Copy link
Contributor

@haydenbaker haydenbaker commented Jun 18, 2024

Background

  • We have two JReleaser configurations: one for main smithy releases, and one for releasing the CLI itself
  • Currently, when running a release, both configurations are used and therefore both releases happen concurrently
  • When something goes wrong, it can be difficult to track down the issue, since the logs for each release become intertwined
  • By adding a property to control which configuration to apply, we can easily switch between main releases and CLI releases
  • We can also remove the stale configuration from the old way of releasing using nexus-staging
  • Also, update to latest version of JReleaser (1.12.0)

Testing

  • To verify configurations, you can run with --dry-run to see the task order:
    • Do not set a property
      • JReleaser is not configured
    • Set main: ./gradlew jreleaserConfig -P release.main --dry-run
      • JReleaser is only configured for a main release
    • Set cli: ./gradlew jreleaserConfig -P release.cli --dry-run
      • JReleaser is only configured for a CLI release
    • Set both: ./gradlew jreleaserConfig -P release.main -P release.cli --dry-run
      • JReleaser is configured for both (if that's what you really want)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haydenbaker haydenbaker requested a review from a team as a code owner June 18, 2024 01:05
@haydenbaker haydenbaker requested review from JordonPhillips and hpmellema and removed request for JordonPhillips June 18, 2024 01:05
@haydenbaker haydenbaker changed the title Add properties for controlling JReleaser confurations Add properties for controlling JReleaser configurations Jun 18, 2024
@haydenbaker haydenbaker force-pushed the haydebak/update-jreleaser-configuration branch from eef6e62 to 08ba568 Compare June 18, 2024 17:48
@haydenbaker haydenbaker merged commit 9106d59 into main Jun 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants