Add tests for quoted strings in headers #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Nov 16, 2021
| headers: { | ||
| "X-StringList": """ | ||
| a, "b,c", "\"def\"" | ||
| """ |
There was a problem hiding this comment.
This should go on the previous line. By putting it on the next line, it's inserting a "\n".
There was a problem hiding this comment.
Yes, but if I turn that into:
headers: {
"X-StringList": """
a, "b,c", "\"def\"""""
},
Then the entire file doesn't parse. I can work around this by flipping the order of the parameters, or by adding a whitespace (which is ignored according to spec)
| headers: { | ||
| "X-StringList": """ | ||
| a, "b,c", "\"def\"" | ||
| """ |
There was a problem hiding this comment.
Same issue - needs to be on the previous line
RFC 7230 sec 3.2.6 defines header values as potentially quoted strings, which makes commas in header values unambiguous. It's also the only way to escape a reserved character. This adds a test for list values with a comma and for list values with escaped double quotes.
adamthom-amzn
force-pushed
the
http-header-protocol-tests
branch
from
3cbfeef
to
58c7c12
Compare
mtdowling
approved these changes
Nov 16, 2021
This was referenced Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
RFC 7230 sec 3.2.6 defines header values as potentially quoted strings, which
makes commas in header values unambiguous. It's also the only way to escape a
reserved character. This adds a test for list values with a comma and for list
values with escaped double quotes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.