CharBuffer.addSlice does not properly handle starting offsets

[Skyb0rg007]

Version

110.99.3 (Latest)

Operating System

• Any
• Linux
• macOS
• Windows
• Other Unix

OS Version

Processor

• Any
• Arm (using Rosetta)
• PowerPC
• Sparc
• x86 (32-bit)
• x86-64 (64-bit)
• Other

System Component

SML/NJ Library

Severity

Minor

Description

CharBuffer.addSlice ignores the substring's starting offset.

Transcript

- val buf = CharBuffer.new 0;
- val substr = Substring.extract ("foo", 1, NONE);
- Substring.string substr;
val it = "oo" : string
- val () = CharBuffer.addSlice (buf, substr);
- CharBuffer.contents buf;
val it = "fo" : string

Expected Behavior

- val buf = CharBuffer.new 0;
- val () = CharBuffer.addSlice (buf, Substring.extract ("foo", 1, NONE));
- CharBuffer.contents buf;
val it = "oo" : string

Steps to Reproduce

- val buf = CharBuffer.new 0;
- val () = CharBuffer.addSlice (buf, Substring.extract ("foo", 1, NONE));
- CharBuffer.contents buf;
val it = "fo" : string

Additional Information

The same issue occurs with CharBuffer.addArrSlice.

Email address

ssoss AT uchicago DOT edu

[JohnReppy]

This bug was present in both the CharBuffer and Word8Buffer structures; it has been fixed for 110.99.4 (and for 2023.1).