Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEEEReal.decimal_approx does not match the Basis Library #74

Closed
1 of 5 tasks
JohnReppy opened this issue Jul 15, 2022 · 0 comments
Closed
1 of 5 tasks

IEEEReal.decimal_approx does not match the Basis Library #74

JohnReppy opened this issue Jul 15, 2022 · 0 comments
Assignees
Labels
basis-lib problem with Standard ML Basis library bug Something isn't working fixed-in-110.99.3 issues that will be fixed in the 110.99.3 version floating-point problem related to floating-point operations gforge bug (or feature request) ported from smlnj-gforge repository

Comments

@JohnReppy
Copy link
Contributor

JohnReppy commented Jul 15, 2022

Version

110.99

Operating System

  • All
  • Linux
  • macOS
  • Windows
  • Other Unix

OS Version

No response

Processor

Any

Component

Basis Library

Severity

Minor

Description of the problem

In the Basis Library, the type IEEEReal.decimal_approx has a field class.
https://smlfamily.github.io/Basis/ieee-float.html#SIG:IEEE_REAL.decimal_approx:TY
but in SML/NJ the field is called kind instead of class:

type decimal_approx =
    {digits:int list, exp:int, kind:IEEEReal.float_class, sign:bool}

Consequently code using this field is not portable.

Transcript

No response

Expected Behavior

No response

Steps to Reproduce

#class (valOf (IEEEReal.fromString "1.0"));

fails but should evaluate to NORMAL.

Additional Information

No response

Email address

phil.clayton@veonix.com

Comments from smlnj-gforge

Original smlnj-gforge bug number 318

Submitted via web form by Phil Clayton phil.clayton@veonix.com on 2022-07-06 at 08:55:00

Keywords: reals

comment by @JohnReppy on 2022-07-06 13:25:00 +000 UTC

Fixed for 110.99.3 and 2022.1

@JohnReppy JohnReppy added basis-lib problem with Standard ML Basis library bug Something isn't working floating-point problem related to floating-point operations gforge bug (or feature request) ported from smlnj-gforge repository labels Jul 15, 2022
@JohnReppy JohnReppy self-assigned this Jul 15, 2022
@JohnReppy JohnReppy added the fixed-in-110.99.3 issues that will be fixed in the 110.99.3 version label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basis-lib problem with Standard ML Basis library bug Something isn't working fixed-in-110.99.3 issues that will be fixed in the 110.99.3 version floating-point problem related to floating-point operations gforge bug (or feature request) ported from smlnj-gforge repository
Projects
None yet
Development

No branches or pull requests

1 participant