Skip to content

IEEEReal.decimal_approx does not match the Basis Library #74

@JohnReppy

Description

@JohnReppy

Version

110.99

Operating System

  • All
  • Linux
  • macOS
  • Windows
  • Other Unix

OS Version

No response

Processor

Any

Component

Basis Library

Severity

Minor

Description of the problem

In the Basis Library, the type IEEEReal.decimal_approx has a field class.
https://smlfamily.github.io/Basis/ieee-float.html#SIG:IEEE_REAL.decimal_approx:TY
but in SML/NJ the field is called kind instead of class:

type decimal_approx =
    {digits:int list, exp:int, kind:IEEEReal.float_class, sign:bool}

Consequently code using this field is not portable.

Transcript

No response

Expected Behavior

No response

Steps to Reproduce

#class (valOf (IEEEReal.fromString "1.0"));

fails but should evaluate to NORMAL.

Additional Information

No response

Email address

phil.clayton@veonix.com

Comments from smlnj-gforge

Original smlnj-gforge bug number 318

Submitted via web form by Phil Clayton phil.clayton@veonix.com on 2022-07-06 at 08:55:00

Keywords: reals

comment by @JohnReppy on 2022-07-06 13:25:00 +000 UTC

Fixed for 110.99.3 and 2022.1

Metadata

Metadata

Assignees

Labels

basis-libproblem with Standard ML Basis librarybugSomething isn't workingfixed-in-110.99.3issues that will be fixed in the 110.99.3 versionfloating-pointproblem related to floating-point operationsgforgebug (or feature request) ported from smlnj-gforge repository

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions