Fix VectorSlice.all and ArraySlice.all#264
Merged
Merged
Conversation
These functions had the same implementation as the exists functions. CharArraySlice.all was correct; the other implementations are updated to match.
JohnReppy
approved these changes
Dec 19, 2022
JohnReppy
left a comment
JohnReppy
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thanks for the fix.
JohnReppy
added
fixed-in-110.99.4
JohnReppy
added a commit
to smlnj/smlnj
that referenced
this pull request
Dec 19, 2022
to development branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These functions had the same implementation as the exists functions. CharArraySlice.all was correct; the other implementations are updated to match.
This should be applied to the the development version as well.
Related Issue
n/a
Motivation and Context
Bug fix.
How Has This Been Tested?
I built SML/NJ and confirmed that the function works as expected.