Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERF] Remove Quadratic Traversal in register_internal #69

Closed
2 tasks
iamrecursion opened this issue Sep 7, 2023 · 0 comments · Fixed by #96
Closed
2 tasks

[PERF] Remove Quadratic Traversal in register_internal #69

iamrecursion opened this issue Sep 7, 2023 · 0 comments · Fixed by #96
Labels
enhancement New feature or request

Comments

@iamrecursion
Copy link
Contributor

Description

Currently we call is_stable_typed inside register_internal, both of which to DFS traversals of the data. This results in quadratic traversal of the value trees when registering.

Instead, the result of is_stable_typed could be returned alongside the TCBoxedVal from register_internal, making this traversal linear again.

Spec

  • Fix the thing.
  • No changes to the tests should be necessary.
@iamrecursion iamrecursion added the enhancement New feature or request label Sep 7, 2023
@iamrecursion iamrecursion changed the title [TASK] Remove Quadratic Traversal in register_internal [PERF] Remove Quadratic Traversal in register_internal Sep 11, 2023
@iamrecursion iamrecursion mentioned this issue Sep 20, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Share liberally in the analyzer smlxl/storage-layout-extractor
1 participant
@iamrecursion